Ticket #730 (new enhancement)

Opened 19 months ago

Last modified 4 months ago

[patch]DDL builder to config unique key for ORACLE

Reported by: ktz <kazu.ktz.tamura@…> Owned by: hans
Priority: normal Milestone: 1.6
Component: Generator Version: 1.3.0
Severity: normal Keywords: oracle generator SQL
Cc: carsten.hetzel@…

Description (last modified by francois) (diff)

I wrote patch DDL builder for oracle. By this patch, it is possible to add uneque key query generation for ORACLE.

I have implemented briefly ,so please review carefully.

Best regards.

Attachments

OracleDDLBuilder.patch Download (1.2 KB) - added by ktz <kazu.ktz.tamura@…> 19 months ago.
patch of DDl generator for oracle

Change History

Changed 19 months ago by ktz <kazu.ktz.tamura@…>

patch of DDl generator for oracle

comment:1 Changed 4 months ago by Carsten

  • Cc carsten.hetzel@… added

Hello,

I wonder why this patch has never been approved? "unique" constraints are not supported without this patch and we have Propel 1.5 already.

Any chance to get this on 1.5?

Regards, Carsten

comment:2 Changed 4 months ago by Carsten

Some more comments on this:

  • "$this->prefixTablename( $table->getName() )" doesn't work - I assume $table->getName() should do.
  • To benefit from unique columns, DBAs often generate more indexes containing unique columns. Such indexes are declared as unique and preferred by the oracle optimizer. So, it would be great if indexes were allowed to be unique, too, even if the set of columns do not need an explicit unique constraint (that's checked by the index itself).

Regards, Carsten

comment:3 Changed 4 months ago by francois

  • Description modified (diff)
  • Milestone changed from To be scheduled to 1.6
Note: See TracTickets for help on using tickets.